Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted fixes for MSVC 2017 #341

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Aug 16, 2023

There are some issues with MSVC 2017.

Namely it struggles mightily with common_reference_with and weakly_incrementable

I have no idea where things go wrong. Im my analysis of the failing tests each atom of common_reference_with was satisfied on its own but put together it would fail.

Given that 2017 is not receiving any updates I went ahead and simply ddisabled whatever is failing

@miscco miscco requested review from a team as code owners August 16, 2023 12:53
@miscco miscco requested review from griwes and wmaxey and removed request for a team August 16, 2023 12:53
@miscco miscco added nvbug Has an associated internal NVIDIA NVBug. libcu++ For all items related to libcu++ bug Something isn't working right. labels Aug 16, 2023
@miscco
Copy link
Collaborator Author

miscco commented Aug 16, 2023

With this I am getting:

C:\src\cccl\libcudacxx\build>lit test/std/ -sv
lit: C:\src\cccl\libcudacxx\test\lit.cfg:45: note: Using configuration variant: libcudacxx
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:364: note: inferred use_system_cxx_lib as: None
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:249: note: detected cxx.type as: nvcc
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:251: note: detected cxx.version as: (12, 2, 91)
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:253: note: detected cxx.default_dialect as: c++14
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:255: note: detected cxx.is_nvrtc as: False
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:283: note: detected host_cxx.type as: msvc
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:285: note: detected host_cxx.version as: (19, 16, 27050)
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:287: note: detected host_cxx.default_dialect as: c++14
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:289: note: detected host_cxx.is_nvrtc as: False
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:391: note: inferred use_clang_verify as: False
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:667: note: inferred language dialect as: c++17
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\target_info.py:67: warning: The locale Czech_Czech Republic.1250 is not supported by your platform. Some tests will be unsupported.
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:484: note: inferred long_tests as: True
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:160: note: Using compiler: C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v12.2/bin/nvcc.exe
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:161: note: Using flags: ['-v', '-ftemplate-depth=270']
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:165: note: Using compile flags: ['-std=c++17', '-IC:/src/cccl/libcudacxx\\include', '-Xcompiler', '/GR-', '-D_SILENCE_CXX20_CISO646_REMOVED_WARNING', '-D_LIBCUDACXX_NO_RTTI', '-IC:/src/cccl/libcudacxx\\test/support', '-D_CRT_SECURE_NO_WARNINGS', '-DNOMINMAX', '-Xcompiler', '/bigobj', '-include', 'C:/src/cccl/libcudacxx/test/force_include.h', '-IC:/src/cccl/libcudacxx/include', '--extended-lambda']
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:168: note: Using warnings: ['-Xcudafe', '--display_error_number', '-Werror=all-warnings', '-Xcompiler', '/W4', '-Xcompiler', '/WX', '-Xcompiler', '-wd4100', '-Xcompiler', '-wd4127', '-Xcompiler', '-wd4180', '-Xcompiler', '-wd4309', '-Xcompiler', '-wd4996']
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:169: note: Using link flags: ['-lmsvcrt']
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:171: note: Using available_features: ['libcpp-no-rtti', 'msvc', 'libcpp-no-exceptions', 'windows', 'nvcc-12.2', 'nvcc-12', 'long_tests', 'locale.en_US.UTF-8', 'locale.fr_CA.ISO8859-1', 'locale.fr_FR.UTF-8', 'msvc-19.16', 'pre-sm-60', 'c++filesystem-disabled', 'msvc-19', 'nvcc', 'libc++', 'pre-sm-32', 'nvcc-12.2.91', 'LIBCUDACXX-WINDOWS-FIXME', 'pre-sm-70', 'dylib-has-no-filesystem', 'win32', 'c++17', 'pre-sm-90', 'no-aligned-allocation', 'pre-sm-80', 'locale.ru_RU.UTF-8', 'locale.zh_CN.UTF-8']
lit: C:\src\cccl\libcudacxx\utils\libcudacxx\test\config.py:177: note: Adding environment variables: {}
-- Testing: 1558 tests, 16 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..

Testing Time: 1878.59s
  Unsupported      :  260
  Passed           : 1279
  Expectedly Failed:   19

1 warning(s) in tests

@miscco miscco changed the base branch from branch/2.2.x to main August 16, 2023 16:14
@miscco miscco requested a review from a team as a code owner August 16, 2023 16:14
@miscco miscco force-pushed the fix_test_iterators_for_msvc branch from 51c840b to 914d465 Compare August 16, 2023 16:18
Copy link
Collaborator

@griwes griwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but merge after #350

it seems there are issues to determine `common_reference_with` which is one of the foundational concepts. Funnily enough each individual component of the concept checks out, but put together things happen.
MSVC 2017 does not like them and thinks they are uninitialized at use ...
@miscco miscco force-pushed the fix_test_iterators_for_msvc branch from 914d465 to 5b933ac Compare August 18, 2023 05:53
@miscco miscco merged commit d199b50 into NVIDIA:main Aug 18, 2023
435 checks passed
@miscco miscco deleted the fix_test_iterators_for_msvc branch August 18, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right. libcu++ For all items related to libcu++ nvbug Has an associated internal NVIDIA NVBug.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants