-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted fixes for MSVC 2017 #341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
added
nvbug
Has an associated internal NVIDIA NVBug.
libcu++
For all items related to libcu++
bug
Something isn't working right.
labels
Aug 16, 2023
With this I am getting:
|
miscco
force-pushed
the
fix_test_iterators_for_msvc
branch
from
August 16, 2023 16:18
51c840b
to
914d465
Compare
griwes
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but merge after #350
it seems there are issues to determine `common_reference_with` which is one of the foundational concepts. Funnily enough each individual component of the concept checks out, but put together things happen.
MSVC 2017 does not like them and thinks they are uninitialized at use ...
miscco
force-pushed
the
fix_test_iterators_for_msvc
branch
from
August 18, 2023 05:53
914d465
to
5b933ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some issues with MSVC 2017.
Namely it struggles mightily with
common_reference_with
andweakly_incrementable
I have no idea where things go wrong. Im my analysis of the failing tests each atom of
common_reference_with
was satisfied on its own but put together it would fail.Given that 2017 is not receiving any updates I went ahead and simply ddisabled whatever is failing